Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-setup-instructions #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update-setup-instructions #29

wants to merge 2 commits into from

Conversation

lyashevska
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Sep 16, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/git-lesson/compare/md-outputs..md-outputs-PR-29

The following changes were observed in the rendered markdown documents:

 md5sum.txt |  2 +-
 setup.md   | 63 +++++++++++++++++++++++++++++++-------------------------------
 2 files changed, 32 insertions(+), 33 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-16 20:36:40 +0000

github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@lyashevska lyashevska marked this pull request as draft September 16, 2024 20:13
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@lyashevska lyashevska marked this pull request as ready for review September 23, 2024 08:10
@lyashevska
Copy link
Contributor Author

Fixes #24

Copy link
Contributor

@svenvanderburg svenvanderburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Given that we do some follow-up tasks as mentioned in #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants