Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17-ssh-instructions #31

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

17-ssh-instructions #31

wants to merge 8 commits into from

Conversation

lyashevska
Copy link
Contributor

This PR improves ssh and other setup instructions.
Some of the instructions are clarified and made self-contained.
Fixes #17 #18 #30

Copy link

github-actions bot commented Sep 23, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/git-lesson/compare/md-outputs..md-outputs-PR-31

The following changes were observed in the rendered markdown documents:

 md5sum.txt |   2 +-
 setup.md   | 163 ++++++++++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 136 insertions(+), 29 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-21 14:29:12 +0000

github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
```bash
ssh-keygen -t ed25519 -C "[email protected]"
```
When you're prompted to "Enter a file in which to save the key", you can press Enter to accept the default file location.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include a note here about passphrases? We could flat-out recommend not using one unless requiring the extra security.

Otherwise I think we should at least indicate that if they decide to use a non-empty passphrase, they'll have to enter it every time they use the SSH key?

Copy link

@ClaireDons ClaireDons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some simple instruction for git in MacOS. If we are not already, perhaps we could point to github's guide on installing git for additional information? https://github.com/git-guides/install-git


:::::::::::::::: spoiler
### Mac
Mac

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most versions of MacOS will have git preinstalled, you can check by running git version in the terminal. If it is not available, you can install git through homebrew by running:
brew install git

github-actions bot pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH instructions on github.com changed
3 participants