Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 'NumKeypad' module to match tab name 'Record' #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tjsr
Copy link

@tjsr tjsr commented Feb 3, 2025

For consistency with other pages, I have refactored the NumKeypad.py module to 'Record.py', and split out the relevant code so that only the Keypad related code now exists in its own module.

I'd like to have this implemented so that I can start doing more major work to these components including:

  • Adding better hints for the user what is going on if they try to use these controls but it appears nothing occurs (such as when they have no race file open, or other situations I've encountered where it doesn't accept or process the crossing).
  • Splitting out the keypad tabs more granularly so that code can be better worked on and tested in isolation.
  • Start utilising better logging from Add Log util class #162
  • Clean up inconsistent button and font usage

@tjsr
Copy link
Author

tjsr commented Feb 3, 2025

I would also suggest that all of the page tab classes be renamed to *Page.

This gives them a consistent name and makes it clear their intended usage within the application as a UI view, rather than either an individual control or controller class/module.

@tjsr tjsr force-pushed the develop/refactor/record branch from cc55bb7 to b58d865 Compare February 25, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant