New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: style issues in no-js mode #628

Merged

amareshsm merged 5 commits into eslint:main from Tanujkanti4441:fix-no-js

Nov 14, 2024

Contributor

Tanujkanti4441 commented Sep 17, 2024

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

There are some styles that are different in no-js mode as compared enabled javascript mode.

What changes did you make? (Give an overview)

This PR fixes following style in no-js mode.

JavaScript Enabled	JavaScript Disabled

Related Issues

Is there anything you'd like reviewers to focus on?


          fix: style issues in no-js mode

eslint-github-bot bot added the bug label

netlify bot commented Sep 17, 2024 •

edited

Loading

✅ Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`34736e4`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/672c6f835415940008556fb6
😎 Deploy Preview	https://deploy-preview-628--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Sep 17, 2024 •

edited

Loading

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`34736e4`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/672c6f834d8e1900083592fd
😎 Deploy Preview	https://deploy-preview-628--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Sep 17, 2024 •

edited

Loading

✅ Deploy Preview for es-eslint ready!

Name	Link
🔨 Latest commit	`34736e4`
🔍 Latest deploy log	https://app.netlify.com/sites/es-eslint/deploys/672c6f831b10db0008477433
😎 Deploy Preview	https://deploy-preview-628--es-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Sep 17, 2024 •

edited

Loading

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`34736e4`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/672c6f83ffe8cc0008b8cbf9
😎 Deploy Preview	https://deploy-preview-628--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Sep 17, 2024 •

edited

Loading

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`34736e4`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/672c6f8326dd0d00083ff886
😎 Deploy Preview	https://deploy-preview-628--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Sep 17, 2024 •

edited

Loading

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`34736e4`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/672c6f83f1637d00088a4a4e
😎 Deploy Preview	https://deploy-preview-628--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Sep 17, 2024 •

edited

Loading

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`34736e4`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/672c6f838e3f0f0008f57bfe
😎 Deploy Preview	https://deploy-preview-628--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Sep 17, 2024 •

edited

Loading

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`34736e4`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/672c6f8300d6c000084cdbb5
😎 Deploy Preview	https://deploy-preview-628--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amareshsm reviewed

View reviewed changes

Member

amareshsm left a comment

Please fix the lint issue; Prettier is failing.

amareshsm added the accepted label


          fix linting error

e0e5fb5

Member

amareshsm commented Sep 22, 2024 •

edited

Loading

A few issues still need to be addressed:

On the donation page, the GitHub company logo is not visible in the "Ways to Sponsor" section when using dark theme in no-JS mode.

Need to correct the styling for the code blocks.


          fix github logo and code color

8fad811

amareshsm reviewed

View reviewed changes

Member

amareshsm left a comment

In the light theme ESLint logo is not visible

Contributor Author

Tanujkanti4441 commented Sep 27, 2024 •

edited

Loading

In the light theme ESLint logo is not visible

I could not reproduce this, can you please share if it is in js or no-js mode, or any steps to reproduce?

Member

amareshsm commented Sep 27, 2024

In the light theme ESLint logo is not visible

I could not reproduce this, can you please share if it is in js or no-js mode, or any steps to reproduce?

I can reproduce this issue locally. you can check this preview link in the no-js mode light theme the ESlint logo is not visible.


          fix logo issue and typo

7519c04

amareshsm reviewed

View reviewed changes

Member

amareshsm left a comment

@Tanujkanti4441 Hey can you this pr once I checked it looks like all of the issues are fixed.

Contributor Author

Tanujkanti4441 commented Oct 25, 2024

@Tanujkanti4441 Hey can you this pr once I checked it looks like all of the issues are fixed.

We still have font-weight related issues as eslint/eslint#18916 PR


          access font from scss

34736e4

Member

harish-sethuraman commented Nov 13, 2024

Screenshot 2024-11-13 at 10 50 21 PM

I can see this isn't working? 🤔 IG this is powered by css / scripts from the other repo? so its fine?

Member

amareshsm commented Nov 13, 2024

I can see this isn't working? 🤔 IG this is powered by css / scripts from the other repo? so its fine?

Which page? can u add the URL too?

Contributor Author

Tanujkanti4441 commented Nov 14, 2024

I can see this isn't working? 🤔 IG this is powered by css / scripts from the other repo? so its fine?

I think it's the getting started page of docs and this is not the part of eslint.org repo that is already fixed in eslint/eslint#18916 PR.

harish-sethuraman approved these changes

View reviewed changes

Member

harish-sethuraman left a comment

LGTM. Thanks for working on this PR.

amareshsm approved these changes

View reviewed changes

Member

amareshsm left a comment

LGTM. Thanks

amareshsm merged commit c20cb98 into eslint:main

37 checks passed

Tanujkanti4441 deleted the fix-no-js branch

November 14, 2024 14:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels