Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-155: Adds JSON Patch Action example #162

Merged
merged 14 commits into from
Dec 14, 2022
Merged

Conversation

DiegoPino
Copy link
Member

See #155

@aksm @alliomeria any of you could give this a quick typo-proof read and suggest directly code/changes as comments?

Gracias

@DiegoPino DiegoPino added the documentation Improvements or additions to documentation label Dec 14, 2022
Copy link
Contributor

@alliomeria alliomeria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads really well @DiegoPino, is a great explanation and walkthrough for JSON Patch. I made a few small potential formatting suggestions, but may/may not all be applicable.

docs/find_and_replace_action_json_patch.md Outdated Show resolved Hide resolved
docs/find_and_replace_action_json_patch.md Outdated Show resolved Hide resolved
docs/find_and_replace_action_json_patch.md Outdated Show resolved Hide resolved
docs/find_and_replace_action_json_patch.md Outdated Show resolved Hide resolved
docs/find_and_replace_action_json_patch.md Outdated Show resolved Hide resolved
docs/find_and_replace_action_json_patch.md Show resolved Hide resolved
@DiegoPino
Copy link
Member Author

Thanks @alliomeria gosh so many issues. Thanks for your sharp eyes on this

@DiegoPino
Copy link
Member Author

@aksm thanks for your corrections. Ok will merge. Let's see how this looks on MKDocs (if it looks at all or not!)

@DiegoPino DiegoPino merged commit fdfbb1c into 1.0.0 Dec 14, 2022
@DiegoPino DiegoPino deleted the ISSUE-155-diegopino branch December 14, 2022 14:46
@alliomeria alliomeria linked an issue Dec 14, 2022 that may be closed by this pull request
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Updates (Macro)
3 participants