Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume we always have inttypes.h and stdint.h (both from C99) #1655

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

bmah888
Copy link
Contributor

@bmah888 bmah888 commented Feb 29, 2024

This eliminates some compile-time tests that didn't really work as desired and aren't easy to fix. It also removes conditional compilation in a number of places.

Note that there were already instances of unconditionally including <inttypes.h> and <stdint.h> in the iperf3 source code, so in practice we had somehow already made this assumption.

Inspired by comments on PR #1636.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master

  • Issues fixed (if any):

  • Brief description of code changes (suitable for use as a commit message):

This eliminates some compile-time tests that didn't really work
as desired and aren't easy to fix.

Inspired by comments on PR #1636.
@bmah888 bmah888 self-assigned this Feb 29, 2024
@bmah888
Copy link
Contributor Author

bmah888 commented Feb 29, 2024

Tagging @davidBar-On and @yumkam in case they have any comments.

@bmah888 bmah888 requested a review from swlars February 29, 2024 20:19
Copy link
Contributor

@swlars swlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We might want to take a closer look at used/unused includes at some point.

@bmah888 bmah888 merged commit c362e1a into master Mar 5, 2024
2 of 6 checks passed
@bmah888 bmah888 deleted the bmah-assume-c99-int-headers branch March 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants