fix static analysis

esp-cpp · Feb 28, 2024 · 26996ce · 26996ce
1 parent 4c1cbab
commit 26996ce
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/components/hid-rp/include/hid-rp-gamepad.hpp b/components/hid-rp/include/hid-rp-gamepad.hpp
@@ -1,5 +1,7 @@
 #pragma once
 
+#include <algorithm>
+
 #include "hid-rp.hpp"
 
 namespace espp {
@@ -57,12 +59,8 @@ class GamepadReport : public hid::report::base<hid::report::type::INPUT, REPORT_
 public:
   /// Reset the gamepad inputs
   constexpr void reset() {
-    for (auto &axis : joystick_axes) {
-      axis = joystick_center;
-    }
-    for (auto &axis : trigger_axes) {
-      axis = trigger_center;
-    }
+    std::fill(joystick_axes.begin(), joystick_axes.end(), joystick_center);
+    std::fill(trigger_axes.begin(), trigger_axes.end(), trigger_center);
     set_hat(Hat::CENTERED);
     buttons.reset();
   }

diff --git a/components/hid-rp/include/hid/page/button.hpp b/components/hid-rp/include/hid/page/button.hpp
@@ -13,7 +13,7 @@ template <> struct info<button> {
 class button {
 public:
   constexpr operator usage_id_t() const { return id; }
-  constexpr button(std::uint8_t value)
+  explicit constexpr button(std::uint8_t value)
       : id(value) {}
   std::uint8_t id{};
 };