Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tla2528): fix use of std::accumulate #138

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

finger563
Copy link
Contributor

Description

  • Properly store result of std::accumulate when configuring tla2528 digital i/o and analog inputs

Motivation and Context

When updating TLA2528 to use std::accumulate for #137 static analysis results, I inadvertently introduced a bug which did not properly configure the digital and analog inputs so the peripheral would not function correctly.

How has this been tested?

  • Building the TLA2528 example
  • Building and running with TLA2528 component in a different project.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Properly store result of std::accumulate when configuring tla2528 digital i/o and analog inputs
@finger563 finger563 added bug Something isn't working tla2528 TLA2528 analog/digital expander labels Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 7b711fd into main Jan 8, 2024
48 checks passed
@finger563 finger563 deleted the bug/tla2528-accumulate branch January 8, 2024 21:25
@finger563 finger563 mentioned this pull request Jan 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tla2528 TLA2528 analog/digital expander
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant