Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(max1704x): remove unused and unimplemented destructor #142

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

finger563
Copy link
Contributor

Description

Motivation and Context

Allows you to dynamically allocate (e.g. with std::shared_ptr) a Max1704x object.

How has this been tested?

In the esp-cpp/esp-box-emu project

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 added bug Something isn't working max1704x labels Jan 14, 2024
@finger563 finger563 merged commit 59a252e into main Jan 14, 2024
16 checks passed
@finger563 finger563 deleted the fix/max17048 branch January 14, 2024 18:12
Copy link

✅Static analysis result - no issues found! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working max1704x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant