Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(display): Add missing component requirements to display component #147

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Feb 5, 2024

Description

Add led and driver to the list of component requirements for the display component.

Motivation and Context

If you include the display or display_drivers component, without also including the led and driver components, then you will get a build failure. This fixes that issue by ensuring that the display component (which is used by the display_drivers component) directly includes those components.

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Feb 5, 2024
@finger563 finger563 added bug Something isn't working display drivers labels Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit d4b93b9 into main Feb 6, 2024
49 checks passed
@finger563 finger563 deleted the fix/display-requirements branch February 6, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working display drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant