feat(base_peripheral): make BasePeripheral a template on size of register address #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster addresses * Update base peripheral component to be a template class whith template argument being the type for the register address (default uint8_t) * Updated all subclasses to include the required <> for using the default type of uint8_t
|
✅Static analysis result - no issues found! ✅ |
* Update how multi-byte registers are handled in base_peripheral and add additional logging for help debugging * Update gt911 and st25dv to subclass with register size 16 bit
* IT_STS is in DATA address space not SYST address space * Change IT_STS from class to bitfield struct so that we can use it when returning the interrupt status * Added priting and comparison for IT_STS * Update example to decrease logging in ST25, use new IT_STS logging, and update clock speed to 1MHz
* Added methods for updating specific members of the config or the config as a whole
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gt911andst25dvclasses to specialize withuint16_tas theRegisterAddressTypebool BasePeripheral::probe(std::error_code&)as public functionvoid BasePeripheral::set_address(uint8_t)as public functionvoid BasePeripheral::set_probe(...)as public functionvoid BasePeripheral::set_write(...)as public functionvoid BasePeripheral::set_read(...)as public functionvoid BasePeripheral::set_read_register(...)as public functionvoid BasePeripheral::set_write_then_read(...)as public functionvoid BasePeripheral::set_config(...)as public functionst25dvfrom Feature/base peripheral #150 which readIT_STSregister fromSYSTaddress space instead ofDATAaddress spaceMotivation and Context
Improves the applicability and reuse of the base peripheral component to support peripherals which have 16 bit register addresses (such as the
st25dvandgt911components)How has this been tested?
gt911examplest25dvexampleScreenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Gt911:
St25dv:
Testing new i2c logging:
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.