Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tla2528): fix bug when compiling with speed optimization enabled #155

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Feb 14, 2024

Description

Change initialization of array to remove = {0}; which throws an error when compiling for speed.

Motivation and Context

If you try to compile the tla2528 and enable speed optimization, you'll get a compiler error, this fixes that.

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Feb 14, 2024
@finger563 finger563 added bug Something isn't working tla2528 TLA2528 analog/digital expander compiler optimization labels Feb 14, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 4211e07 into main Feb 14, 2024
5 checks passed
@finger563 finger563 deleted the bug/tla2528-speed-optimization-fix branch February 14, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler optimization tla2528 TLA2528 analog/digital expander
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant