Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ble): added missing sdkconfig include #176

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Mar 8, 2024

Description

Add missing #include <sdkconfig.h> to ble_gatt_server and hid_service components (gfps_service already included it)

Motivation and Context

#175 caused a regression where cloud builds and first builds could fail, but subsequent builds would work. This is caused by missing inclusion of sdkconfig.h that this PR fixes.

How has this been tested?

Building tests in CI on this PR.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Copy link

github-actions bot commented Mar 8, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 34e5132 into main Mar 8, 2024
54 checks passed
@finger563 finger563 deleted the fix/missing-sdkconfig-include branch March 8, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant