Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): expose some types for convenience and better backwards compatibility #178

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Expose some of the underlying Interrupt types via the Button class which match the previous APIs available to Button.

Motivation and Context

Enables more seamless upgrade from the previous Button to the new Button (with Interupt base class).

How has this been tested?

Building and running the examples.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Mar 12, 2024
@finger563 finger563 added enhancement New feature or request button labels Mar 12, 2024
@finger563 finger563 merged commit a81e05c into main Mar 12, 2024
55 checks passed
@finger563 finger563 deleted the feature/button-api-convenience branch March 12, 2024 13:17
Copy link

✅Static analysis result - no issues found! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
button enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant