Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event_manager): Allow fully configuring subscriber task #179

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Add API to support providing a full Task::BaseConfig when registering a subscriber, so that you can optionally specify name, stack size, priority, and pinned core id
  • Update event manager example to use new API
  • Update task to have libfmt printing helpers for task config and base config.

Motivation and Context

Prior to this PR, you could only (optionally) set the stack size for a subscriber task, but could not set the priority or the core id for the task. This would mean you could not for instance set higher priority to higher priority event subscribers and you could not pin them to a specific core for resource management. Additionally, you could not name the task whatever you liked.

How has this been tested?

Building and running the event manager example

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-03-12 at 08 26 17

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…ubscriber task

* Add API to support providing a full Task::BaseConfig when registering a subscriber, so that you can optionally specify name, stack size, priority, and pinned core id
* Update event manager example to use new API
* Update task to have libfmt printing helpers for task config and base config.
@finger563 finger563 self-assigned this Mar 12, 2024
@finger563 finger563 added enhancement New feature or request event manager labels Mar 12, 2024
@finger563 finger563 changed the title feat(event_manager): Update Event Manager to support full config of subscriber task feat(event_manager): Update Event Manager to support fully configuring subscriber task Mar 12, 2024
@finger563 finger563 changed the title feat(event_manager): Update Event Manager to support fully configuring subscriber task feat(event_manager): Allow fully configuring subscriber task Mar 12, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 2ba3aad into main Mar 12, 2024
55 checks passed
@finger563 finger563 deleted the feature/event-manager-task-config branch March 12, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request event manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant