Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i2c): Add I2cMenu to i2c component #182

Merged
merged 4 commits into from
Mar 12, 2024
Merged

feat(i2c): Add I2cMenu to i2c component #182

merged 4 commits into from
Mar 12, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Mar 12, 2024

Description

  • Move I2cMenu from component example into component so that others can use it more effectively
  • Update menu to allow easier reuse / subclassing and to be within the espp namespace
  • Add protection around menu so that it allows compilation if exceptions are disabled.
  • Also added a note to various places about the scan operation in the example / menu taking a while with the default ESP-IDF due to the excessively long timeout (1 second) that is configured by default and can only be changed by modifying i2c.c.

Motivation and Context

Allows others to reuse and subclass the i2c menu more effectively.

How has this been tested?

Building and running the i2c example both with exceptions enabled and with exceptions disabled.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Move I2cMenu from component example into component so that others can use it more effectively
* Update menu to allow easier reuse / subclassing and to be within the espp namespace
* Add protection around menu so that it allows compilation if exceptions are disabled.
@finger563 finger563 self-assigned this Mar 12, 2024
@finger563 finger563 added enhancement New feature or request examples i2c labels Mar 12, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 788e510 into main Mar 12, 2024
55 checks passed
@finger563 finger563 deleted the feature/i2c-menu branch March 12, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request examples i2c
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant