Add espp::SsRoundDisplay hardware abstraction component for the Seeed Studio Round Display
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…drivers since that is the actual requirement
… the display - including built-in defines for xiao s3 and qtpys3
|
✅Static analysis result - no issues found! ✅ |
… that in the constructor to log an error if no pin config is provided
…; minor refactor and update some defaults
SquaredPotato
pushed a commit
to smartknob-ha/espp
that referenced
this pull request
Jan 27, 2025
…ed Studio Round Display (esp-cpp#315) * add seeed-studio-round-display component and example * remove esp-lcd from component requires, instead adding it to display_drivers since that is the actual requirement * Update to support interface for definiting what pins are connected to the display - including built-in defines for xiao s3 and qtpys3 * update display config * minor update to example * add comments * doc: update * -ci: update * add missing chsc6x touch driver component * wip final updates * added default values for the pinconfig and comparison operators - use that in the constructor to log an error if no pin config is provided * refactor for readability * flesh out docs some more * add chsc6x example and update workflow * update readme * update docs * fix bug in chsc6x not returning true when there was actually new data; minor refactor and update some defaults * readme: update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
seeed-studio-round-displaycomponent with examplechsc6xtouch driver componentMotivation and Context
It's a nice little round display dev board, this PR adds a hardware abstraction component enabling easier building of applications for that hardware.
How has this been tested?
Building and running the new example on the xiao s3 connected to the display.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
seeed_studio_round_display_compressed.mp4
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.