Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): Add espp::task::run_on_core_non_blocking static method #331

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Add method for running a function on specific core without blocking the thread. Resources for the thread will be automatically cleaned up.

Motivation and Context

Similar to espp::task::run_on_core, we'd like to be able to run functions on specific cores without creating and managing a espp::Task, so that once the function completes, the thread resources will be automatically cleaned up, and we'd like to be able to start the work without blocking the calling thread context.

How has this been tested?

Building and running task/example on a QtPy ESP32s3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-09-23 at 14 40 36

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Sep 23, 2024
@finger563 finger563 added enhancement New feature or request tasks labels Sep 23, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 1810367 into main Sep 23, 2024
69 checks passed
@finger563 finger563 deleted the feature/task-run-on-core-nonblocking branch September 23, 2024 20:09
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant