Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): [BREAKING] Simplify task configuration #342

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Rename Task::AdvancedConfig to Task::Config
  • Remove Task::SimpleConfig

Motivation and Context

Follow-on PR to #341 which updates the Task API so that there is a single Task::Config instead of 3, which could confuse the compiler and add needless complexity to the API.

How has this been tested?

  • Building and running task/example
  • Building the shared library
  • Building pc/python tests

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Rename `Task::AdvancedConfig` to `Task::Config`
* Remove `Task::SimpleConfig`
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 self-assigned this Nov 20, 2024
@finger563 finger563 added enhancement New feature or request tasks labels Nov 20, 2024
@finger563 finger563 merged commit bb71669 into main Nov 20, 2024
69 checks passed
@finger563 finger563 deleted the feat/task-config-refactor branch November 20, 2024 16:33
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
* feat(task): [BREAKING] Simplify task configuration
* Rename `Task::AdvancedConfig` to `Task::Config`
* Remove `Task::SimpleConfig`

* update bindings, rtsp, timer, and ftp components

* fix examples

* fix remaining examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant