feat(interrupt): Improve Interrupt implementation and API #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `enable` / `disable` APIs for specific interrutps * Add `remove` APIs for specific interrupts * Add `remove_all` * Add `disable_all` * Refactor how interrupts are configured somewhat to ensure they are not enabled until after the handler has been registered * Update interrupt PinConfig to have `auto_reenable` flag (default=true) to mirror previous behavior, but to allow the interrupt to not re-trigger until explicitly re-enabled by the caller. * Add more info about interrupt configuration to class doc
|
✅Static analysis result - no issues found! ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable/disableAPIs for specific interrutpsremoveAPIs for specific interruptsremove_alldisable_allauto_reenableflag (default=true) to mirror previous behavior, but to allow the interrupt to not re-trigger until explicitly re-enabled by the caller.Motivation and Context
More complex use of the interrupts class necessitated being able to manually enable/disable interrupts via caller code. This update also enables better use of level interrupts in addition to edge interrupts.
How has this been tested?
interrupt/exampleon QtPy ESP32s3.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.