Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ble): Update esp-nimble-cpp and simplify BleGattServer #350

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Dec 6, 2024

Description

  • Update esp-nimble-cpp submodule to have new server-client code
  • Update BleGattServer to remove extra client pointer used for getting name / rssi from connected clients, instead using the new client that is managed within the server itself.

Motivation and Context

  • Simplifies the BleGattServer
  • Keeps esp-nimble-cpp up to date for compatibility and maintenance

How has this been tested?

Building and running hid_service/example on QtPy ESP32s3 and testing with iPhone

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-12-05 at 22 40 37

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update esp-nimble-cpp submodule to have new server-client code
* Update `BleGattServer` to remove extra `client` pointer used for getting name / rssi from connected clients, instead using the new client that is managed within the server itself.
Copy link

github-actions bot commented Dec 6, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 7976f35 into main Dec 6, 2024
69 checks passed
@finger563 finger563 deleted the feat/ble_gatt_server_use_server_client branch December 6, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant