Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(task): call vTaskDelete at end of std::thread in task::run_on_core_non_blocking #353

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Dec 19, 2024

Description

  • Ensure the detached task function calls vTaskDelete(nullptr) instead of returning. It is not needed in the Task itself because we do a join on that thread instead of detaching

Motivation and Context

Ensures that we follow the spec for what you must do when exiting the return function in FreeRTOS tasks under all conditions.

How has this been tested?

Building and running task/example on QtPy ESP32s3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-12-19 at 09 54 10

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…n_core_non_blocking`

* Ensure the detached task function calls `vTaskDelete(nullptr)` instead of returning. It is not needed in the `Task` itself because we do a `join` on that thread instead of detaching
@finger563 finger563 self-assigned this Dec 19, 2024
@finger563 finger563 added bug Something isn't working tasks labels Dec 19, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 32367dd into main Dec 19, 2024
69 checks passed
@finger563 finger563 deleted the fix/task-run-on-core-non-blocking branch December 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant