Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp Patch for esp-nimble-cpp #355

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

finger563
Copy link
Contributor

Description

  • Update esp-nimble-cpp to follow esp-cpp/esp-nimble-cpp:fix/270-crash branch for critical fix when reconnecting

Motivation and Context

Pull in the fix for h2zero/esp-nimble-cpp#270 early

This is temporary, till upstream pulls in h2zero/esp-nimble-cpp#271

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update esp-nimble-cpp to follow esp-cpp/esp-nimble-cpp:fix/270-crash branch for critical fix when reconnecting
@finger563 finger563 self-assigned this Dec 20, 2024
@finger563 finger563 added esp-nimble-cpp bug Something isn't working labels Dec 20, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit f40b8b9 into main Dec 20, 2024
69 checks passed
@finger563 finger563 deleted the fix/esp-nimble-cpp-reconnect branch December 20, 2024 20:20
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
* Update esp-nimble-cpp to follow esp-cpp/esp-nimble-cpp:fix/270-crash branch for critical fix when reconnecting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working esp-nimble-cpp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant