Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(led): Update to allow configuration of the led sleep mode #359

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Jan 10, 2025

Description

  • Update LED to allow configuration of sleep mode behavior if using ESP-IDF >= 5.4

Motivation and Context

As of 5.4, if you want your LED to work in sleep mode, you have to explicitly enable it (while still also using a light-sleep enabled clock source). This PR makes it so that that configuration option is configurable from user application code and sets the default to have the LED enabled during light sleep (if the clock source allows). Application code can now choose to disable light sleep LED behavior using the ESP-IDF provided configuration parameter.

How has this been tested?

  • Building and running the led/example
  • Running in a project with light sleep

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Jan 10, 2025
@finger563 finger563 added enhancement New feature or request led labels Jan 10, 2025
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit da19abf into main Jan 10, 2025
68 of 69 checks passed
@finger563 finger563 deleted the feat/led-sleep-mode-config branch January 10, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request led
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant