feat(hid): Add xbox battery input report #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `espp::XboxBatteryInputReport` to `hid-rp-gamepad.hpp` * Update `hid-rp/example` to check compilation * Update `hid_service/example` to actually use and test the battery report
|
✅Static analysis result - no issues found! ✅ |
SquaredPotato
pushed a commit
to smartknob-ha/espp
that referenced
this pull request
Jan 27, 2025
* feat(hid): Add xbox battery input report * Add `espp::XboxBatteryInputReport` to `hid-rp-gamepad.hpp` * Update `hid-rp/example` to check compilation * Update `hid_service/example` to actually use and test the battery report * fix missing copy-paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
espp::XboxBatteryInputReporttohid-rp-gamepad.hpphid-rp/exampleto check compilationhid_service/exampleto actually use and test the battery reportMotivation and Context
Some systems (such as iOS) show battery status as part of their gamepad display - and this status is different from the
BatteryService. To be able to have some control over this, we need to implement this report type.This is especially important when masquerading as an Xbox controller.
How has this been tested?
Building and running
hid_service/exampleon QtPy ESP32s3 and checking on iPhone to make sure theGameControllersscreen inSettings>Generalshows the updating battery level there.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Note: battery service still shows correct info in the batteries widget:
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.