Rework LCD_CAM

esp-rs · Oct 30, 2024 · cf609a1 · cf609a1
1 parent 8d0442d
commit cf609a1
Show file tree

Hide file tree

Showing 4 changed files with 209 additions and 225 deletions.
diff --git a/esp-hal/src/lcd_cam/cam.rs b/esp-hal/src/lcd_cam/cam.rs
@@ -81,7 +81,7 @@ use crate::{
         OutputSignal,
         Pull,
     },
-    lcd_cam::{cam::private::RxPins, private::calculate_clkm, BitOrder, ByteOrder},
+    lcd_cam::{calculate_clkm, BitOrder, ByteOrder},
     peripheral::{Peripheral, PeripheralRef},
     peripherals::LCD_CAM,
 };
@@ -604,8 +604,7 @@ impl RxPins for RxSixteenBits {
     const BUS_WIDTH: usize = 2;
 }
 
-mod private {
-    pub trait RxPins {
-        const BUS_WIDTH: usize;
-    }
+#[doc(hidden)]
+pub trait RxPins {
+    const BUS_WIDTH: usize;
 }
diff --git a/esp-hal/src/lcd_cam/lcd/i8080.rs b/esp-hal/src/lcd_cam/lcd/i8080.rs
@@ -75,12 +75,13 @@ use crate::{
         OutputSignal,
     },
     lcd_cam::{
-        asynch::LCD_DONE_WAKER,
-        lcd::{i8080::private::TxPins, ClockMode, DelayMode, Phase, Polarity},
-        private::{calculate_clkm, Instance},
+        calculate_clkm,
+        lcd::{ClockMode, DelayMode, Phase, Polarity},
         BitOrder,
         ByteOrder,
+        Instance,
         Lcd,
+        LCD_DONE_WAKER,
     },
     peripheral::{Peripheral, PeripheralRef},
     peripherals::LCD_CAM,
@@ -703,8 +704,7 @@ impl<'d> TxPins for TxSixteenBits<'d> {
     }
 }
 
-mod private {
-    pub trait TxPins {
-        fn configure(&mut self);
-    }
+#[doc(hidden)]
+pub trait TxPins {
+    fn configure(&mut self);
 }