Rework i2c

[bugadani]

• Split implementation in versioned modules
• No more doc(hidden) trait methods
• apply_config, with_sda/scl
• embassy_embedded_hal::SetConfig
• the master driver has been moved to i2c::master so we don't have to move it when introducing slave
• transaction now chunks reads and writes

cc #2416 and closes #1919

[bugadani]

This commit is a bit of an experimental idea, I'd love to hear feedback on it!

[bjoernQ]

This commit is a bit of an experimental idea, I'd love to hear feedback on it!

I wonder which commit that was since the link goes nowhere now

[bugadani]

This commit is a bit of an experimental idea, I'd love to hear feedback on it!

I wonder which commit that was since the link goes nowhere now

2013299

[bjoernQ]

I like the version module - wonder if any other peripheral would be a good fit for something like that (I think most peripherals are not that bad in terms of different versions - so maybe none)

I also like the idea of pulling eh impls into separate (quite small) files

[bugadani]

We don't need to split apart every other driver and we can only extract the differing bits as well. There is enough overlapping code to make this scheme somewhat awkward although I'm biased towards liking the idea.

[MabezDev]

I think for I2C, given the wild differences between chips, this version file structure makes sense. I think it's unlikely that we'll adopt this for any other driver (unless I'm missing one, AFAIK the rest of the drivers are similar enough between chips) until new chips come out that warrant the change.

[MabezDev]

This diff looks quite goofy, but I'm trusting that you've just been rearranging some things and that it is correct.

[bugadani]

Yeah I'm not that confident (I mean the changes are OK, the reason behind them is shaky). I couldn't decide how to organize things, and I think per-peripheral is better than per-topic (e.g. config changes, constructor changes, etc.).

[jessebraham]

This should be split into multiple PRs IMO, it's essentially impossible to review something of this size in any meaningful way.

[bugadani]

I can send in each commit separately if that helps.