Systimer improvements #2451
Merged
Systimer improvements #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominaezzz
reviewed
Nov 2, 2024
Dominaezzz
reviewed
Nov 2, 2024
| .modify(|_, w| w.update().set_bit()); | ||
| } | ||
| /// Reads the current counter value. | ||
| fn read_count(&self) -> u64 { |
There was a problem hiding this comment.
Any objections against moving this synchronization logic into Alarm and leaving Unit as the low level API (i.e. update and poll)?
There was a problem hiding this comment.
Not much, besides the desire to not expose footgun parts.
There was a problem hiding this comment.
Now that read_count() is expensive, do I have a stronger argument? 😄
There was a problem hiding this comment.
How about now, now that it's cheap again? 🙃
There was a problem hiding this comment.
Yeah I don't think I have a strong enough case anymore haha
Dominaezzz
reviewed
Nov 2, 2024
Dominaezzz
reviewed
Nov 2, 2024
| .modify(|_, w| w.update().set_bit()); | ||
| } | ||
| /// Reads the current counter value. | ||
| fn read_count(&self) -> u64 { |
There was a problem hiding this comment.
Now that read_count() is expensive, do I have a stronger argument? 😄
bjoernQ
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2431
Closes #2432
At least in theory, I did not spend time reproducing the race issue. I do not think we can test the race condition easily so I didn't add a test case.