Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new Package for Discord Markdown Formatting #124

Merged
merged 16 commits into from
Aug 6, 2024

Conversation

NathanelM
Copy link
Contributor

This is a snippets package for Discord Markdown Formatting.

@smeech
Copy link
Collaborator

smeech commented Aug 5, 2024

A nice package of simple expansions.
One (possibly unnecessary) benign shell: single-liner. No other scripts or malicious code.
Could be merged, but I have made a few suggestions to conform to our conventions.

@NathanelM NathanelM requested a review from smeech August 6, 2024 08:25
@NathanelM
Copy link
Contributor Author

Hi,
Thanks for your review. I made the change that you suggested. Can you check if this is correct?

@NathanelM NathanelM requested a review from smeech August 6, 2024 10:29
@smeech
Copy link
Collaborator

smeech commented Aug 6, 2024

Thank you - that all looks good. I'll go ahead and merge. It'll take half an hour or so for the Hub to pick it up.

@smeech smeech merged commit 1a0db2b into espanso:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants