Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package linter-control-comments (Golint, Rubocop/Ruby, Clippy/Rust and Shellcheck) #132

Merged
merged 9 commits into from
Oct 26, 2024

Conversation

katrinleinweber
Copy link
Contributor

@katrinleinweber katrinleinweber commented Oct 11, 2024

This is intended to provide editor-independent access to comments like # rubocop:disable …, //nolint:… etc. in order to control linter behaviour in source code files.

They make heavy use of the {clipboard}, into which one can copy a particular linting rule name (from docs, terminal output, etc.) before triggering the espansion.

Would this be a useful addition here?

PS: The specific snippets are just a rough start. Not necessarily complete with respect to what their respective docs list as available, nor based on any analysis of real-world usage.

@smeech
Copy link
Collaborator

smeech commented Oct 13, 2024

Thank you, @katrinleinweber.

I've run the CI, which has passed, but this message is primarily to acknowledge your submission, and to let you know that as I'm about 10k miles from my PC, it'll probably be a couple of weeks before I can consider merging, unless someone else intervenes.

In the meantime, would you kindly add a homepage: key/value pair to _manifest.yml, even if it just points to https://github.com/katrinleinweber/espanso-hub/tree/package-linter-control-comments, as we've had problems merging some packages where this is omitted. Do make other amendments in the meantime if you wish. Perhaps add a "linter" tag.

I'm intrigued by your use of {clipboard} (with its single curly-braces) and how that works in comparison to the Espanso clipboard extension, and frustrated that I can't test it here!

@katrinleinweber katrinleinweber force-pushed the package-linter-control-comments branch from fad6916 to 5688286 Compare October 14, 2024 07:02
@katrinleinweber
Copy link
Contributor Author

katrinleinweber commented Oct 14, 2024

Thanks for the clipboard hint, @smeech! I must have remembered it incorrectly, and fixed the syntax now.

@smeech
Copy link
Collaborator

smeech commented Oct 14, 2024

Thank you! I thought I'd missed something!

For reference, a package of ten simple trigger/replacements utilising a clipboard global-variable. No script, cmd: or malicious code.

I'l approve for merge when I'm home in a couple of weeks.

@smeech smeech merged commit 64c3fa0 into espanso:main Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants