Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add expand-contractions-en package #95

Merged
merged 9 commits into from
Sep 14, 2024
Merged

Conversation

lewisblackburn
Copy link
Contributor

This expands contractions e.g. aren'tare not .

This is useful for when writing essays, as professional writing often requires a more formal and precise language style, eliminating contractions contributes to a more polished and academic tone.

Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice, straightforward package of simple expansions.
No cmd, script, shell or malicious code.
Both README.md and package.yml would benefit from removing duplicates, and, ideally, sorting into alphabetical order. Let me know if you need any help.
Then it will be safe to merge.

@smeech smeech added the invalid This doesn't seem right label May 6, 2024
@smeech
Copy link
Collaborator

smeech commented Sep 12, 2024

I presume you're still working on this - just to let you know I am keeping an eye on it.

@smeech smeech marked this pull request as draft September 12, 2024 13:23
@lewisblackburn
Copy link
Contributor Author

I think everything should be ready to go now, I'd be happy make any more changes. I apologise if there are any mistakes as I am still learning how to use GitHub 😅

@smeech
Copy link
Collaborator

smeech commented Sep 13, 2024

I've lost track of the _manifest.yml and README.md files and can't see the contents of your package.yml. You may need to copy them from https://github.com/lewisblackburn/espanso-expand-contractions-en to your updated copy of espanso/hub, in a version folder, and submit a fresh PR with the whole set, having removed the espanso-contractions-en Submodule.

Don't worry - I've learned a lot in the last few months!

@smeech smeech changed the title feat: Add expand-contractions package feat: Add expand-contractions-en package Sep 14, 2024
@smeech
Copy link
Collaborator

smeech commented Sep 14, 2024

Thank you - we're getting there!

Would you kindly:

please?

@lewisblackburn
Copy link
Contributor Author

Yes of course no worries, I will do that ASAP. Thanks for your patience.

@smeech smeech marked this pull request as ready for review September 14, 2024 16:16
@smeech
Copy link
Collaborator

smeech commented Sep 14, 2024

I'm afraid you omitted a period in /0.1.0/ so it's reading /0.10/.

Can you remove the old folder and contents (without the version number), please? While I could delete the files, I might not be able to remove their folder, which may cause problems.

@lewisblackburn
Copy link
Contributor Author

Oh okay sorry about that, one second

@lewisblackburn
Copy link
Contributor Author

Should I add the correct folder back?

@smeech
Copy link
Collaborator

smeech commented Sep 14, 2024

You may have removed the wrong one. All I can see now in the file-list is the folder and files without the version number.

We'll get there!

@smeech
Copy link
Collaborator

smeech commented Sep 14, 2024

We're now back to two folders, both named /espanso-contractions-en/0.1.0/, I'm afraid. We just need one.

@smeech
Copy link
Collaborator

smeech commented Sep 14, 2024

The folder needs the package name: expand-contractions-en, as in _manifest.yml. Sorry - I should have spotted that earlier.

@lewisblackburn
Copy link
Contributor Author

lewisblackburn commented Sep 14, 2024

I think that should have fixed it (I hope)

@smeech smeech merged commit e7b0883 into espanso:main Sep 14, 2024
1 check passed
@smeech
Copy link
Collaborator

smeech commented Sep 14, 2024

Thank you. I've gone ahead with the merge. The package can be found at https://hub.espanso.org/expand-contractions-en. espanso install expand-contractions-en works.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants