Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial rollback of #223 to fix install error on M5 Stack Atom Echo #233

Closed
wants to merge 1 commit into from

Conversation

HarvsG
Copy link
Contributor

@HarvsG HarvsG commented Jul 10, 2024

Fixes #227

Since #223 / a79c9fa local installation of the firmware on the M5 Stack Atom Echo fails due to image size, see:

Rolling back to cd57ca6 worked for many users as can be seen on this comment and below on #227

This yaml also works for me

substitutions:
  name: m5stack-atom-echo-b836b0
  friendly_name: M5Stack Atom Echo b836b0
packages:
  m5stack.atom-echo-voice-assistant: github://esphome/firmware/voice-assistant/m5stack-atom-echo.yaml@main
esphome:
  name: ${name}
  name_add_mac_suffix: false
  friendly_name: ${friendly_name}
api:
  encryption:
    key: +yourAPIKEY=


wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password

# HarvsG's customisations 2024-07-10, will likely break UI updating in HomeAssistant and 
# can be deleted once https://github.com/esphome/firmware/issues/227 is fixed
update:
  - platform: http_request
    id: !remove update_http_request

This narrows the issue down to:

update:
- platform: http_request
id: update_http_request
name: Firmware
source: https://firmware.esphome.io/voice-assistant/m5stack-atom-echo/manifest.json
.

Now since it seems to be an image size issue, I guess it is possible that removing any component may improve things, but it seems sensible to roll back the most recent.

NB: My tests were done on 2024.6.6
Edit: It may be worth widening the scope of the rollback as #228 seems related to PR #223 as well.

@almoney
Copy link

almoney commented Jul 10, 2024

INFO ESPHome 2024.6.6
INFO Reading configuration /config/esphome/m5stack-atom-echo-23ed4c.yaml...
INFO Updating https://github.com/esphome/esphome.git@pull/5230/head
INFO Updating https://github.com/jesserockz/esphome-components.git@None
INFO Generating C++ source...
INFO Updating https://github.com/espressif/[email protected]
INFO Updating submodules (components/esp-sr, components/esp-adf-libs) for https://github.com/espressif/[email protected]
INFO Updating https://github.com/espressif/[email protected]
INFO Compiling app...
Processing m5stack-atom-echo-23ed4c (board: m5stack-atom; framework: espidf; platform: platformio/[email protected])
--------------------------------------------------------------------------------
HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash
 - framework-espidf @ 3.40407.240606 (4.4.7) 
 - tool-cmake @ 3.16.9 
 - tool-ninja @ 1.10.2 
 - toolchain-esp32ulp @ 2.35.0-20220830 
 - toolchain-xtensa-esp32 @ 8.4.0+2021r2-patch5
Reading CMake configuration...
Dependency Graph
|-- noise-c @ 0.1.4
|-- ArduinoJson @ 6.18.5
|-- Improv @ 1.2.3
*** [.pioenvs/m5stack-atom-echo-23ed4c/src/esphome/components/http_request/update/http_request_update.o] Source `src/esphome/components/http_request/update/http_request_update.cpp' not found, needed by target `.pioenvs/m5stack-atom-echo-23ed4c/src/esphome/components/http_request/update/http_request_update.o'.
========================== [FAILED] Took 5.32 seconds ==========================

I am getting this when trying to build with this config:

substitutions:
  name: m5stack-atom-echo-23ed4c
  friendly_name: M5Stack Atom Echo 23ed4c
packages:
  m5stack.atom-echo-voice-assistant: github://esphome/firmware/voice-assistant/m5stack-atom-echo.yaml@main
esphome:
  name: ${name}
  name_add_mac_suffix: false
  friendly_name: ${friendly_name}
api:
  encryption:
    key: nnn


wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password

# HarvsG's customisations 2024-07-10, will likely break UI updating in HomeAssistant and 
# can be deleted once https://github.com/esphome/firmware/issues/227 is fixed
update:
  - platform: http_request
    id: !remove update_http_request
    name: Firmware 
    source: https://firmware.esphome.io/voice-assistant/m5stack-atom-echo/manifest.json

@HarvsG
Copy link
Contributor Author

HarvsG commented Jul 18, 2024

    name: Firmware 
    source: https://firmware.esphome.io/voice-assistant/m5stack-atom-echo/manifest.json

Remove these two lines. And clean the build files.
Works on esphome 2024.7.0 for me

@txwindsurfer
Copy link

The fix by @HarvsG doesn't work for me with my M5 Stack Atom Echos (5 of them). Rolled back to ESPHome 2024.6.4. Did the new update with ESPHome 2024.7.1 address this problem?

@HarvsG
Copy link
Contributor Author

HarvsG commented Jul 22, 2024

The fix by @HarvsG doesn't work for me with my M5 Stack Atom Echos (5 of them). Rolled back to ESPHome 2024.6.4. Did the new update with ESPHome 2024.7.1 address this problem?

Other fixes are discussed in #227
I haven't tested 2024.7.1 but I see nothing in the changelog to suggest it has fixed it.

@jesserockz
Copy link
Member

Replaced by #244

@jesserockz jesserockz closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M5 Stack Atom Echo VA firmware does not install locally since a79c9fa - image too big.
4 participants