Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uart): adds Serial4 as a keyword - used by ESP32-P4 #10619

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

SuGlider
Copy link
Collaborator

Description of Change

ESP32-P4 has 5 HardwareSerial Objects.
Arduino IDE highlights Serial to Serial3, but not Serial4.
This PR adds Serial4 as a keyword.

Tests scenarios

Usinf Arduino ide 1.8.9

Related links

None

@SuGlider SuGlider added this to the 3.1.0 milestone Nov 18, 2024
@SuGlider SuGlider self-assigned this Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 18, 2024

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f533329

@lucasssvaz lucasssvaz added the Status: Pending Merge Pull Request is ready to be merged label Nov 18, 2024
@me-no-dev me-no-dev merged commit 2b6b5c7 into release/v3.1.x Nov 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Peripheral: UART Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants