Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zigbee): Add IAS Zone endpoints (Contact Switch + Door/Window Handle) #10918

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR adds 2 new endpoints, both using IAS Zone cluster:

  • Contact Switch (open/close states)
  • Door/Window Handle (open/close/tilted)

also added an example for the contact switch, as this type is supported by the HomeAssistant.

Tests scenarios

Tested using ESP32-C6 connecting to the Zigbee network running under HomeAssistant.

Related links

Closes #10870

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review Area: Zigbee Issues and Feature Request about Zigbee labels Jan 30, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.2.0 milestone Jan 30, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9db2963

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C60⚠️ +1000.00⚠️ +0.02000.000.00
ESP32H20⚠️ +1000.00⚠️ +0.02000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_CarbonDioxide_Sensor⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_Color_Dimmable_Light⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_Color_Dimmer_Switch⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_Contact_Switch----
Zigbee/examples/Zigbee_Dimmable_Light⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_Occupancy_Sensor⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_On_Off_Light⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_On_Off_Switch⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_Pressure_Flow_Sensor⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_Scan_Networks⚠️ +700⚠️ +700
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_Temperature_Sensor⚠️ +1000⚠️ +1000
Zigbee/examples/Zigbee_Thermostat⚠️ +1000⚠️ +1000

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Test Results

 62 files   62 suites   5m 57s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
154 runs  154 ✅ 0 💤 0 ❌

Results for commit 9db2963.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 30, 2025
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check CI spell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Zigbee Issues and Feature Request about Zigbee Status: Pending Merge Pull Request is ready to be merged
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

zigbee example for door/window sensor
4 participants