Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsp: New generic BSP (spiffs, sdcard, i2c, buttons). #223

Merged
merged 1 commit into from
Nov 14, 2023
Merged

bsp: New generic BSP (spiffs, sdcard, i2c, buttons). #223

merged 1 commit into from
Nov 14, 2023

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Sep 13, 2023 •
edited by tore-espressif
Loading

Checklist for new Board Support package or Component

  • Component contains License
  • Component contains README.md
  • Project README.md updated
  • Component contains idf_component.yml file with url field defined
  • Component was added to CI upload job
  • New files were added to CI build job
  • New BSP definitions added to bsp_ext.py
  • BSP was added to SquareLine
  • New BSP supports IDF v4.4.x and later releases
  • Optional: Component contains unit tests
  • CI passing

Change description

The first draft of generic BSP for discussion. I didn't want to add more things (leds, LCDs, audio), because it will be complicated for review. I suggesting make each part in one PR, what do you think?

@espzav
Copy link
Collaborator Author

espzav commented Sep 14, 2023

@tore-espressif & @igrr please could you look at it and let's discuss your opinions

tore-espressif
tore-espressif reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nitpicks/comments

esp_bsp_generic/esp_bsp_generic.c Outdated Show resolved Hide resolved
esp_bsp_generic/include/bsp/esp_bsp_generic.h Outdated Show resolved Hide resolved
esp_bsp_generic/README.md Outdated Show resolved Hide resolved
esp_bsp_generic/Kconfig Outdated Show resolved Hide resolved
esp_bsp_generic/Kconfig Outdated Show resolved Hide resolved
@espzav espzav force-pushed the bsp/generic branch 9 times, most recently from 27d5ba4 to 9da8666 Compare October 17, 2023 12:08
@espzav
Copy link
Collaborator Author

espzav commented Oct 27, 2023

Waiting for update of the led_indicator component: https://gitlab.espressif.cn:6688/ae_group/esp-iot-solution/-/merge_requests/873

@espzav espzav force-pushed the bsp/generic branch 4 times, most recently from 2cb1d7b to 878fd69 Compare November 2, 2023 06:39
@espzav
Copy link
Collaborator Author

espzav commented Nov 3, 2023

The LED support is finished. @tore-espressif @igrr PTAL

@espzav
Copy link
Collaborator Author

espzav commented Nov 6, 2023 •
edited
Loading

I tried to add this BSP to matter here: https://github.com/espzav/esp-matter/pull/1
Only one example is supported now: "light" and I tested it with ESP32s2 and s3. Only LED On/Off tested from button. I cannot control it from phone without HUB.

tore-espressif
tore-espressif reviewed Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @espzav ! I would like to test your changes with esp-matter before we merge this

examples/generic_button_led/CMakeLists.txt Outdated Show resolved Hide resolved
bsp/esp_bsp_generic/README.md Outdated Show resolved Hide resolved
bsp/esp_bsp_generic/README.md Outdated Show resolved Hide resolved
bsp/esp_bsp_generic/include/bsp/esp_bsp_generic.h Outdated Show resolved Hide resolved
bsp/esp_bsp_generic/include/bsp/esp_bsp_generic.h Show resolved Hide resolved
bsp/esp_bsp_generic/src/led_blink_defaults.c Outdated Show resolved Hide resolved
bsp/esp_bsp_generic/CMakeLists.txt Outdated Show resolved Hide resolved
@espzav
Copy link
Collaborator Author

espzav commented Nov 9, 2023

@tore-espressif Thank you for review! The first matter draft is available here: https://github.com/espzav/esp-matter/pull/1 I am working on add change color and other LED values, waiting for some minor changes in led_indicator (https://gitlab.espressif.cn:6688/ae_group/esp-iot-solution/-/merge_requests/879) and I have some issues with control matter from Amazon app. I tried to contact support on Teams yesterday and I haven't got any response yet.

@espzav espzav force-pushed the bsp/generic branch 2 times, most recently from 081f8ba to f579caa Compare November 14, 2023 08:37
tore-espressif
tore-espressif approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new feature @espzav !

@espzav espzav merged commit af5df95 into master Nov 14, 2023
9 checks passed
@espzav espzav deleted the bsp/generic branch November 14, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tore-espressif tore-espressif tore-espressif approved these changes

@igrr igrr Awaiting requested review from igrr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@espzav @tore-espressif