Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcd: fix breaking change version #248

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

Lzw655
Copy link
Collaborator

@Lzw655 Lzw655 commented Nov 9, 2023

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

  • Increase the major version of components gc9a01 and ili9341
  • Fix some codes

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Nov 9, 2023

@espzav @tore-espressif PTAL, thank you!

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lzw655 Thank you for changes. LGTM, but I don't understand, why major versions were changed in this PR?

@tore-espressif
Copy link
Collaborator

@espzav please see this conversation #244 (comment)

@espzav
Copy link
Collaborator

espzav commented Nov 15, 2023

@espzav please see this conversation #244 (comment)

@tore-espressif Oh, I forgot for this discussion. Thank you. If you are ok with it, we can merge it.

@espzav espzav force-pushed the bugfix/lcd_breaking_change_version branch from daeef5e to 8f6fb58 Compare November 21, 2023 09:35
@Lzw655 Lzw655 force-pushed the bugfix/lcd_breaking_change_version branch from 8f6fb58 to 78a3c6d Compare November 21, 2023 09:41
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@espzav espzav merged commit d864d66 into espressif:master Nov 21, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants