Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc9503: fix madctl default value #254

Merged
merged 1 commit into from
Dec 5, 2023
Merged

gc9503: fix madctl default value #254

merged 1 commit into from
Dec 5, 2023

Conversation

Lzw655
Copy link
Collaborator

@Lzw655 Lzw655 commented Dec 1, 2023 •
edited by espzav
Loading

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

  • The MADCTL command of GC9503 has a default value 0x10
  • If set to 0, the screen will display abnormally when running LVGL.

@Lzw655 Lzw655 force-pushed the lcd/fix_gc9503_madctl_default_value branch from 8850f0f to 2a7465f Compare December 1, 2023 10:50
tore-espressif
tore-espressif approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Dec 1, 2023

@espzav @tore-espressif PTAL, thank you!

@Lzw655 Lzw655 mentioned this pull request Dec 2, 2023
Merged
2 tasks
espzav
espzav approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lzw655 Thank you for this fix. LGTM

@espzav espzav merged commit c92774c into espressif:master Dec 5, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espzav espzav espzav approved these changes

@tore-espressif tore-espressif tore-espressif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lzw655 @tore-espressif @espzav