bsp: Add display and touch support to gerenic BSP. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espzav
force-pushed
the
bsp/generic_lcd
branch
from
7c7a53d to
75b6f01
Compare
There was a problem hiding this comment.
- There is a missing comma at
esp_bsp_generic.c:77and similarly below. Button ADC fails to compile - It is a little misleading that I can still set 'Number of LEDs' to 5, but I can define only 1 'Classic RGB LED'. Can we hide the 'number of LEDs' menu for classic RGB LEDs?
espzav
force-pushed
the
bsp/generic_lcd
branch
from
75b6f01 to
aadc9a1
Compare
@tore-espressif Thank you for review! Fixed all mistakes and changed LEDs in KConfig - the first select type and then number of leds (zero still means no leds). |
There was a problem hiding this comment.
@espzav Thanks for the updates, I left few comments worth considering.
I will test with a real custom board and LCD tomorrow
espzav
force-pushed
the
bsp/generic_lcd
branch
2 times, most recently
from
2d9751e to
0be3141
Compare
|
@tore-espressif Thank you for the review. Fixed and one comment left. |
There was a problem hiding this comment.
@espzav Thanks for the updates. I tested with ESP32-S3-EYE and found few things that did not work out of the box
espzav
force-pushed
the
bsp/generic_lcd
branch
from
0be3141 to
e01b4f9
Compare
|
@tore-espressif Thank you for the review and HW test. Everything fixed/added. |
espzav
force-pushed
the
bsp/generic_lcd
branch
from
e01b4f9 to
c22c67d
Compare
tore-espressif
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
led_indicatorand support classic RGB LED (e.g. ESP32C2)Issues