Fix(esp_lcd_gc9a01): Missing field initializers and wrong order under C++ (BSP-610) #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
There was a problem hiding this comment.
@tajnymag Thank you for the fix! I left one comment about default values
|
@tore-espressif I've set the pins to -1 as you said and tested the display working correctly. What should I do about the version bump, now being before the latest correcting commit. |
tore-espressif
force-pushed
the
fix/gc9a01-cxx-fix
branch
from
db5f0b8 to
41b7057
Compare
It's OK, we can squash it before merging :) |
tore-espressif
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
GC9A01_PANEL_BUS_SPI_CONFIG and GC9A01_PANEL_IO_SPI_CONFIG macros were causing project to fail to compile in under C++23 (ESP-IDF 5.3.2). I've added initializers with default values for each member and fixed field order in BUS_SPI_CONFIG.