Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Build i2c_example only for IDF >= 5.2 #482

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Jan 14, 2025

Our CI was broken for some time and did not catch this issue.
Could close #481

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Build i2c_example only for IDF >= 5.2

@tore-espressif tore-espressif self-assigned this Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

Test Results

 15 files  15 suites   5m 30s ⏱️
 45 tests 22 ✅  23 💤 0 ❌
330 runs  22 ✅ 308 💤 0 ❌

Results for commit 43616b0.

♻️ This comment has been updated with latest results.

@tore-espressif tore-espressif force-pushed the ci/fix_test_apps branch 2 times, most recently from 8101255 to 6b7b8d8 Compare January 14, 2025 18:25
Our CI was broken for some time and did not catch this issue.
@tore-espressif
Copy link
Collaborator Author

@espzav I'm sorry for the CI issues, this should fix all esp_lvgl_port apps, so we can close #481

@tore-espressif tore-espressif requested a review from espzav January 14, 2025 19:28
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tore-espressif Thank you for the fix. LGTM

@tore-espressif tore-espressif merged commit 446a88f into master Jan 15, 2025
35 checks passed
@tore-espressif tore-espressif deleted the ci/fix_test_apps branch January 15, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants