Fix typo and add add logging feature in the CSI parsing script (AEGHB-760) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2024 15:27
Some variable names of CSI amplitudes have been mistakenly named as "phase_array." Correct them to prevent misunderstandings.
Add a CLI argument in the [csi_data_read_parse.py](examples/get-started/tools/csi_data_read_parse.py) to record corrupted CSI data and other serial output for easier debugging.
github-actions
bot
changed the title
|
Thanks for that. I've pushed this into our internal review & merge queue, PR will be updated once it's merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed variable name typo mentioned in #187
Add logging feature for corrupted data and other serial data #186