Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples]: Test the SLIP netif example on target as well #762

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

david-cermak
Copy link
Collaborator

@david-cermak david-cermak commented Feb 12, 2025

Problem

  • esp_netiff by default uses lwip's netif->state to store it's internal data
  • some non-typical lwip netifs also use this to store internal data (PPP, bridge, wireguard port)

Solution

  • to address this properly we need to fix esp_netif to either keep this reserved or add a Kconfig option to set NETIF_DATA -- will fix in IDF-12473

  • here we provide a workaround to enable PPP netif to force esp_netif not to use the state field

  • also adds target test

  • Closes slip_custom_netif demo not working #759

@david-cermak david-cermak self-assigned this Feb 12, 2025
@david-cermak david-cermak force-pushed the fix/examples_target_tests branch 5 times, most recently from ea5fd6d to 3e8d939 Compare February 12, 2025 17:05
…etif

by enabling PPP netif, so esp_netif knows that lwip's netif->state
will be reserved for special netif info (slip)

Closes espressif#759
@david-cermak david-cermak force-pushed the fix/examples_target_tests branch from 3e8d939 to 2db11bb Compare February 20, 2025 10:59
@david-cermak david-cermak merged commit a22c3da into espressif:master Feb 20, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slip_custom_netif demo not working
2 participants