Apply suggestions from code review

Co-authored-by: Peter Marčišovský <[email protected]>
espressif · Jan 6, 2025 · 0726ee3 · 0726ee3
1 parent cfaefb0
commit 0726ee3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/device/esp_tinyusb/test_apps/dconn_detection/main/test_dconn_detection.c b/device/esp_tinyusb/test_apps/dconn_detection/main/test_dconn_detection.c
@@ -106,7 +106,7 @@ void tud_umount_cb(void)
  * - Install TinyUSB Device stack without any class
  * - In cycle:
  *      - Emulate the detachment, get the tud_umount_cb(), increase the dev_umounted value
- *      - Enulate the attachment, get the tud_mount_cb(), increase the dev_mounted value
+ *      - Emulate the attachment, get the tud_mount_cb(), increase the dev_mounted value
  * - Verify that dev_umounted == dev_mounted
  * - Verify that dev_mounted == DEVICE_DETACH_TEST_ROUNDS, where DEVICE_DETACH_TEST_ROUNDS - amount of rounds
  * - Uninstall TinyUSB Device stack

diff --git a/device/esp_tinyusb/test_apps/dconn_detection/pytest_dconn_detection.py b/device/esp_tinyusb/test_apps/dconn_detection/pytest_dconn_detection.py
@@ -8,6 +8,6 @@
 @pytest.mark.esp32s2
 @pytest.mark.esp32s3
 @pytest.mark.esp32p4             
-#@pytest.mark.usb_device             Disable in CI: unavailable tearget for P4
+#@pytest.mark.usb_device             Disable in CI: unavailable teardown for P4
 def test_usb_device_dconn_detection(dut: IdfDut) -> None:
     dut.run_all_single_board_cases(group='dconn')
diff --git a/device/esp_tinyusb/test_apps/dconn_detection/sdkconfig.defaults b/device/esp_tinyusb/test_apps/dconn_detection/sdkconfig.defaults
@@ -1,7 +1,7 @@
 # Configure TinyUSB, it will be used to mock USB devices
 CONFIG_TINYUSB_MSC_ENABLED=n
-CONFIG_TINYUSB_CDC_ENABLED=y
-CONFIG_TINYUSB_CDC_COUNT=2
+CONFIG_TINYUSB_CDC_ENABLED=n
+CONFIG_TINYUSB_CDC_COUNT=0
 CONFIG_TINYUSB_HID_COUNT=0
 
 # Disable watchdogs, they'd get triggered during unity interactive menu