Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(usb_host_uvc): support dual camera with hub (IEC-246) #109
base: master
Are you sure you want to change the base?
feat(usb_host_uvc): support dual camera with hub (IEC-246) #109
Changes from all commits
3fa43ce
290d524
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern aligns with the issues flagged by the static analyzer: the use of dynamic memory allocation.
This violates the principle of ownership in dynamic memory management—if you allocate memory, it's your responsibility to ensure it is properly freed. Relying on others to manage memory you allocate can lead to resource leaks or undefined behavior. Consider revising this to avoid dynamic allocation or clearly define ownership and the lifecycle of the allocated memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API needs to be designed to be called twice: the first call retrieves the list length, and after the user allocates sufficient memory, the second call fills the data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this:
uvc_host_driver_event_data_t
) gives user number of frame formats.uvc_host_frame_info_t
) and passes pointer and size of this array touvc_desc_get_frame_list
, which fills the arraySo it could look like this
Check warning
Code scanning / clang-tidy
Potential leak of memory pointed to by 'frame_info' [clang-analyzer-unix.Malloc] Warning
Check warning
Code scanning / clang-tidy
Potential leak of memory pointed to by 'new_frame_info' [clang-analyzer-unix.Malloc] Warning