esp_tinyusb v1.4.4: Adding FS configuration descriptor for HS device

[roma-jam]

esp_tinyusb v1.4.4 (Release)

General description

• USB Device now able to work with both Hosts: High Speed (HS) or Full Speed (FS)

Changes

• Moved all the descriptor preparation logic inside descriptor_control.c file, tinyusb_set_descriptors(..). This function is responsible for descriptors preparation based on the tinyusb configuration, provided during tinyusb driver install.
• Renamed default descriptors from *_kconfig to *_default.
• Added descriptor_hs_cfg_default[] for HighSpeed device and descriptor_hs_cfg_default[] for FullSpeed device.
• Added .hs_cfg_desc field to tinyusb configuration (only when TUD_OPT_HIGH_SPEED is set)
• Added .qualifier_desc field to tinyusb configuration (only when TUD_OPT_HIGH_SPEED is set)

Details

Configuration descriptor definitions:

1. FS only
   1.1 Configuration descriptor NOT present (.configuration_descriptor = NULL). Default FS compatible configuration descriptor is using.
   1.2 Configuration descriptor PRESENT (.configuration_descriptor != NULL). Provided descriptor is using.
2. HS/FS
   2.1 Configuration descriptor NOT present (.configuration_descriptor = NULL). Default FS compatible configuration descriptor is using.
   2.2 HS configuration descriptor NOT present (.hs_cfg_desc = NULL). Default HS compatible configuration descriptor is using.
   2.3 Configuration descriptor PRESENT (.configuration_descriptor != NULL). Provided FS descriptor is using.
   2.4 HS configuration descriptor PRESENT (.hs_cfg_desc != NULL). Provided HS descriptor is using.

IMPORTANT: In any cases for HS/FS, configuration descriptors must be equal size.

Hints

• For HS/FS field .fs_cfg_desc might be used instead of .configuration_descriptor
• In HS all combinations are possible (2.1/2.2, 2.1/2.4, 2.3/2.2, 2.3/2.4), but HS and FS configuration descriptors must be the same size.
• Device qualifier descriptor must be present if device descriptor is not default. Otherwise, default qualifier descriptor is using.

[tore-espressif]

@roma-jam Thanks for the updates.

My biggest concern is about memory allocation for the descriptors. Previously, if user did not provide his own descriptors, all Kconfig generated descs were statically allocated in esp_tinyusb.
If user provided his descs, he was responsible for making sure that their lifetime is the same as the lifetime of the USB device (usually made static).

This is surely not the best solutions, but it is consistent across the whole esp_tinyusb component and also consistent with TinyUSB upstream examples.

[roma-jam]

@tore-espressif Thanks for the review!
Will follow-up with all suggestions.

[tore-espressif]

@roma-jam Do you think we could increase default debug level to 1 = error in this release?
https://github.com/espressif/esp-usb/blob/master/device/esp_tinyusb/Kconfig#L4

// CFG_TUSB_DEBUG for debugging
// 0 : no debug
// 1 : print error
// 2 : print warning
// 3 : print info

cc @peter-marcisovsky

[tore-espressif]

Thanks @roma-jam , looks better now!

[tore-espressif]

Thank you @roma-jam LGTM.

@Dazza0 PTAL too

[Dazza0]

@roma-jam Left a bunch of nitpicks, but changes LGTM overall

[roma-jam]

USB example verification list (ESP-IDF v5.3-dev-2495-g0bbee51829-dirty, esp32p4)

• tusb_composite_msc_serialdevice
• tusb_console
• tusb_hid (HS configuration descriptor must be provided by user for HID, requires example update)
• tusb_midi (HS configuration descriptor must be provided by user for MIDI, requires example update)
• tusb_msc (HS and Qualifier descriptors must be present (Device Descriptor not default), requires example update)
• tusb_ncm (Unable to build, because there is no WiFi support in esp32p4, exclude from esp32p4 support list?)
• tusb_serial_device