Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp_tinyusb): Uninstall TinyUSB driver while external task is using #115

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Jan 15, 2025

Description

Fixed error during driver uninstall, when esp_tinyusb is configured with CONFIG_TINYUSB_NO_DEFAULT_TASK=y

Related

Prerequisites for run-time TinyUSB configuration:

  • Selecting USB Peripheral
  • TinyUSB task configuring

Testing

Added three additional test applications for two parameters CONFIG_TINYUSB_NO_DEFAULT_TASK and CONFIG_TINYUSB_INIT_IN_DEFAULT_TASK

Test Matrix:

  • Default Task (CONFIG_TINYUSB_NO_DEFAULT_TASK=n, CONFIG_TINYUSB_INIT_IN_DEFAULT_TASK=n )
  • Default Task + Initialization in Task (CONFIG_TINYUSB_NO_DEFAULT_TASK=n, CONFIG_TINYUSB_INIT_IN_DEFAULT_TASK=y )
  • External Task (CONFIG_TINYUSB_NO_DEFAULT_TASK=y)

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@roma-jam roma-jam added this to the esp_tinyusb v1.7.0 milestone Jan 15, 2025
@roma-jam roma-jam self-assigned this Jan 15, 2025
@roma-jam roma-jam changed the base branch from master to feature/esp32p4_fs_phy_config January 15, 2025 20:48
@roma-jam roma-jam force-pushed the feature/tusb_task_test_apps branch from ac9b94c to bb9ab4a Compare January 15, 2025 21:29
@roma-jam roma-jam force-pushed the feature/esp32p4_fs_phy_config branch from 28e9591 to 6f2362b Compare January 17, 2025 09:59
@roma-jam roma-jam force-pushed the feature/tusb_task_test_apps branch from bb9ab4a to 7610ac5 Compare January 17, 2025 10:37
@roma-jam roma-jam force-pushed the feature/tusb_task_test_apps branch from d82c5ba to 3d53009 Compare January 17, 2025 10:39
@roma-jam roma-jam changed the base branch from feature/esp32p4_fs_phy_config to master January 17, 2025 10:40
@roma-jam roma-jam marked this pull request as ready for review January 17, 2025 11:22
@roma-jam roma-jam merged commit b347dc2 into master Jan 17, 2025
31 checks passed
@roma-jam roma-jam deleted the feature/tusb_task_test_apps branch January 17, 2025 13:18
@roma-jam roma-jam mentioned this pull request Jan 17, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants