-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esp_tinyusb): Uninstall TinyUSB driver while external task is using #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roma-jam
changed the base branch from
master
to
feature/esp32p4_fs_phy_config
January 15, 2025 20:48
roma-jam
force-pushed
the
feature/tusb_task_test_apps
branch
from
January 15, 2025 21:29
ac9b94c
to
bb9ab4a
Compare
roma-jam
commented
Jan 15, 2025
device/esp_tinyusb/test_apps/default_task_with_init/main/test_tusb.c
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/default_task_with_init/sdkconfig.defaults
Outdated
Show resolved
Hide resolved
roma-jam
commented
Jan 15, 2025
roma-jam
force-pushed
the
feature/esp32p4_fs_phy_config
branch
from
January 17, 2025 09:59
28e9591
to
6f2362b
Compare
roma-jam
force-pushed
the
feature/tusb_task_test_apps
branch
from
January 17, 2025 10:37
bb9ab4a
to
7610ac5
Compare
roma-jam
force-pushed
the
feature/tusb_task_test_apps
branch
from
January 17, 2025 10:39
d82c5ba
to
3d53009
Compare
roma-jam
changed the base branch from
feature/esp32p4_fs_phy_config
to
master
January 17, 2025 10:40
tore-espressif
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed error during driver uninstall, when esp_tinyusb is configured with
CONFIG_TINYUSB_NO_DEFAULT_TASK=y
Related
Prerequisites for run-time TinyUSB configuration:
Testing
Added three additional test applications for two parameters
CONFIG_TINYUSB_NO_DEFAULT_TASK
andCONFIG_TINYUSB_INIT_IN_DEFAULT_TASK
Test Matrix:
CONFIG_TINYUSB_NO_DEFAULT_TASK=n
,CONFIG_TINYUSB_INIT_IN_DEFAULT_TASK=n
)CONFIG_TINYUSB_NO_DEFAULT_TASK=n
,CONFIG_TINYUSB_INIT_IN_DEFAULT_TASK=y
)CONFIG_TINYUSB_NO_DEFAULT_TASK=y
)Checklist
Before submitting a Pull Request, please ensure the following: