refactor(esp_tinyusb): Changed CONFIG_TINYUSB_NO_DEFAULT_TASK to non-inverted logic #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding the external or default (handling internally in the esp_tinyusb component) TinyUSB Task for
tud_task()
.Before:
#if !CONFIG_TINYUSB_NO_DEFAULT_TASK
-> then create the TinyUSB task during driver install and handletud_task()
there. The logic holds two negative parts, which increases the difficulty of code readability.After:
#if CONFIG_TINYUSB_DEFAULT_TASK
-> then create the TinyUSB task during driver install and handletud_task()
there.Clear logic: if default task -> then task holds in the driver.
Related
Prerequisites for dynamic TinyUSB configuration:
Selecting USB Peripheral
TinyUSB task configuring
Testing
N/A
Checklist
Before submitting a Pull Request, please ensure the following: