Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(esp_tinyusb): Changed CONFIG_TINYUSB_NO_DEFAULT_TASK to non-inverted logic #116

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Jan 15, 2025

Description

Regarding the external or default (handling internally in the esp_tinyusb component) TinyUSB Task for tud_task().

Before:

#if !CONFIG_TINYUSB_NO_DEFAULT_TASK -> then create the TinyUSB task during driver install and handle tud_task() there. The logic holds two negative parts, which increases the difficulty of code readability.

After:

#if CONFIG_TINYUSB_DEFAULT_TASK -> then create the TinyUSB task during driver install and handle tud_task() there.
Clear logic: if default task -> then task holds in the driver.

Related

Prerequisites for dynamic TinyUSB configuration:

Selecting USB Peripheral
TinyUSB task configuring

Testing

N/A


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@roma-jam roma-jam added this to the esp_tinyusb v1.7.0 milestone Jan 15, 2025
@roma-jam roma-jam self-assigned this Jan 15, 2025
@roma-jam roma-jam force-pushed the refactor/tinyusb_default_task branch from 5c8b9b9 to 84761ff Compare January 15, 2025 21:13
@roma-jam roma-jam changed the title refactor(esp_tinyusb): Changed DEFAULT task configuration to non-inverted logic refactor(esp_tinyusb): Changed CONFIG_TINYUSB_NO_DEFAULT_TASK task configuration to non-inverted logic Jan 15, 2025
@roma-jam roma-jam changed the title refactor(esp_tinyusb): Changed CONFIG_TINYUSB_NO_DEFAULT_TASK task configuration to non-inverted logic refactor(esp_tinyusb): Changed CONFIG_TINYUSB_NO_DEFAULT_TASK config to non-inverted logic Jan 15, 2025
@roma-jam roma-jam changed the title refactor(esp_tinyusb): Changed CONFIG_TINYUSB_NO_DEFAULT_TASK config to non-inverted logic refactor(esp_tinyusb): Changed CONFIG_TINYUSB_NO_DEFAULT_TASK to non-inverted logic Jan 15, 2025
@roma-jam roma-jam force-pushed the feature/tusb_task_test_apps branch from ac9b94c to bb9ab4a Compare January 15, 2025 21:29
@roma-jam roma-jam force-pushed the refactor/tinyusb_default_task branch from 84761ff to 3a9e915 Compare January 15, 2025 21:32
@roma-jam roma-jam force-pushed the feature/tusb_task_test_apps branch 2 times, most recently from d82c5ba to 3d53009 Compare January 17, 2025 10:39
@roma-jam roma-jam removed this from the esp_tinyusb v1.7.0 milestone Jan 17, 2025
Base automatically changed from feature/tusb_task_test_apps to master January 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant