Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update IDF Component Manager version (IEC-258) #127

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

XDanielPaul
Copy link
Contributor

Description

This PR updates the IDF Component Manager version in .build_idf_examples.yml and updates the import in override_managed_component.py

Related

Testing

Changes were tested on a fork of the repository in Github Actions

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 22, 2025
@github-actions github-actions bot changed the title ci: Update IDF Component Manager version ci: Update IDF Component Manager version (IEC-258) Jan 22, 2025
@roma-jam
Copy link
Collaborator

@XDanielPaul Thanks a lot for the PR! Changes LGTM.

@XDanielPaul
Copy link
Contributor Author

XDanielPaul commented Jan 23, 2025

@roma-jam @peter-marcisovsky Thank you for the review!

@tore-espressif
Copy link
Collaborator

@XDanielPaul Could you please check whether it actually works locally?
This is a log from successful run on master 4 days ago https://github.com/espressif/esp-usb/actions/runs/12959690573/job/36152349823#step:4:129
image

The run from your PR does not contain the line. (https://github.com/espressif/esp-usb/actions/runs/12912173476/job/36006360411?pr=127#step:4:107)

The whole purpose of this CI job is, so we can build esp-idf examples with current changes in esp_tinyusb.
If esp_tinyusb is fetched from ESP registry, we won't be able to detect potential issues

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XDanielPaul LGTM, thank you for the update!

@XDanielPaul
Copy link
Contributor Author

@XDanielPaul LGTM, thank you for the update!

@tore-espressif You're welcome, thanks for catching that and for the review!

@tore-espressif tore-espressif merged commit 43cc64e into espressif:master Jan 28, 2025
36 checks passed
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants