Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modem_usb): Add default configuration for more modems #18

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat(modem_usb): Add default configuration for more modems #18

merged 1 commit into from
Mar 7, 2024

Conversation

tore-espressif
Copy link
Collaborator

Added:

  • SimCom SIM7070G modem

@tore-espressif tore-espressif self-assigned this Feb 20, 2024
@peter-marcisovsky
Copy link
Collaborator

peter-marcisovsky commented Mar 1, 2024 •
edited
Loading

Added:

  • SimCom SIMA7672E modem
  • SimCom SIM7080 modem

Fixed:

  • SimCom SIM7070G modem (typo in VID)

@peter-marcisovsky
Copy link
Collaborator

@tore-espressif PTAL

All the modules have been added and the default configurations were tested:
- SimCom SIM7070G
- SimCom SIM7080
- SimCom SIMA7672E

tore-espressif
tore-espressif commented Mar 6, 2024
View reviewed changes
Copy link
Collaborator Author

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about changelog, rest LGTM!

host/class/cdc/esp_modem_usb_dte/CHANGELOG.md Outdated Show resolved Hide resolved
@tore-espressif @peter-marcisovsky
feat(modem_usb): Add default configuration for modems:
36a48ee 
    - SimCom SIM7070G
    - SimCom SIM7080
    - SimCom SIMA7672E
@peter-marcisovsky peter-marcisovsky merged commit 6914ede into master Mar 7, 2024
11 checks passed
@peter-marcisovsky peter-marcisovsky deleted the feat/more_modems branch March 7, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-marcisovsky peter-marcisovsky peter-marcisovsky approved these changes

Assignees

@tore-espressif tore-espressif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tore-espressif @peter-marcisovsky