CI: Add Clang tidy #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
peter-marcisovsky
force-pushed
the
refactor/add_github_workflows
branch
from
2f048e8 to
e5d9a12
Compare
peter-marcisovsky
force-pushed
the
refactor/add_clang_tidy
branch
from
854308c to
264d9f2
Compare
peter-marcisovsky
force-pushed
the
refactor/add_clang_tidy
branch
from
c78fece to
c9fc3df
Compare
peter-marcisovsky
changed the base branch from
refactor/add_github_workflows
to
master
peter-marcisovsky
force-pushed
the
refactor/add_clang_tidy
branch
4 times, most recently
from
402c681 to
e6206c0
Compare
|
@peter-marcisovsky Hit the merge button when ready! |
tore-espressif
force-pushed
the
refactor/add_clang_tidy
branch
from
e6206c0 to
148710a
Compare
peter-marcisovsky
force-pushed
the
refactor/add_clang_tidy
branch
from
148710a to
cb327f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Clang tidy related files.
We wanted to reuse Clang tidy CI job from
idf-extra-components, where Clang tidy job was run from its maintest_app.Since we have split the main
test_appinto into several test apps in this respository an extensive Clang tidy job rework would be needed to run Clang tidy in all the test_apps.We decided to create a folder
clang_tidy, from where Clang tidy is run. Doing so, nearly no modification is needed to be done in the Clang tidy CI job fromidf-extra-components.github/filter_sarif.py- copy fromidf-extra-components(no modification).github/workflows/clang-tidy.yml- copy fromidf-extra-components(line 41 added, line 38 modified folder name)clang_tidyfolder name and content ofclang_tidy/README.mdis opened for discussion.